Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extensions dev mode in binary builds #21

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

alexrashed
Copy link
Member

Motivation

Currently, the extensions dev mode is broken in the binary builds of the CLI. See #20.
This PR adds two hidden imports needed to configure the mounting of extensions from local repositories.

Fixes #20.

Testing

  • Adds a new smoke test which makes sure that the extensions dev mode can be used correctly.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! good to know we need to maintain the list of imports here.

@alexrashed alexrashed merged commit 8de7eb6 into main Jan 3, 2024
6 checks passed
@alexrashed alexrashed deleted the fix-extensions-dev-mode branch January 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency for Extension dev mode?
2 participants