Skip to content

Commit

Permalink
fix extensions dev mode in binary builds (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexrashed authored Jan 3, 2024
1 parent 7abbfd8 commit 8de7eb6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,16 @@ jobs:
# Pull images to avoid making smoke tests vulnerable to system behavior (docker pull speed)
docker pull localstack/localstack-pro
cd dist-bin
# start pro
# start pro with an API key (legacy)
LOCALSTACK_API_KEY=${{ secrets.TEST_LOCALSTACK_API_KEY }} ./localstack start -d
./localstack wait -t 180
./localstack status services --format plain
./localstack status services --format plain | grep "xray=available"
./localstack stop
LOCALSTACK_AUTH_TOKEN=${{ secrets.TEST_LOCALSTACK_AUTH_TOKEN }} ./localstack start -d
# start pro with an auth token and extensions dev mode (see issue #20)
LOCALSTACK_AUTH_TOKEN=${{ secrets.TEST_LOCALSTACK_AUTH_TOKEN }} EXTENSION_DEV_MODE=1 ./localstack start -d
./localstack wait -t 180
./localstack logs | grep "extension developer mode enabled"
./localstack status services --format plain
./localstack status services --format plain | grep "xray=available"
./localstack stop
Expand Down
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ dist-bin/localstack build: $(VENV_ACTIVATE) main.py
--hidden-import cookiecutter.extensions \
--hidden-import localstack_ext.cli.localstack \
--hidden-import localstack_ext.plugins \
--hidden-import localstack.dev.run.configurators \
--hidden-import localstack_ext.extensions.plugins \
--hidden-import localstack_ext.extensions.bootstrap \
--additional-hooks-dir hooks

dist-dir/localstack: PYINSTALLER_ARGS=--distpath=dist-dir
Expand Down

0 comments on commit 8de7eb6

Please sign in to comment.