Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to test against multiple aws-cdk versions #98

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Dec 2, 2024

Motivation

This PR adds a GitHub workflow which main objective is to test the our aws-cdk-local tool agains multiple aws-cdk versions by simply creating a new python project and deploying it in LS.

Explanation

The workflows consists in 2 jobs:

  • generate-cdk-versions-matrix which objective is to pull the list of versions available of aws-cdk and generate a strategy matrix. By default it just gives a list of 11 versions (including latest) manually selected.
  • version-testing grabs the matrix and per each version, installs the CDK lib version, creates a project and tries to deploy it to LS.

Notes

The matrix is limited to 256 items due to GH limits.

@pinzon pinzon force-pushed the workflow-cdk-version branch 2 times, most recently from 7dc1aec to 1159e3b Compare December 2, 2024 20:24
@pinzon pinzon changed the title wip: testing for cdk versions add workflow to test against multiple aws-cdk versions Dec 5, 2024
@pinzon pinzon marked this pull request as ready for review December 5, 2024 02:48
@pinzon pinzon force-pushed the workflow-cdk-version branch from d226916 to c739659 Compare December 5, 2024 15:11
@pinzon
Copy link
Member Author

pinzon commented Dec 5, 2024

That PR fixed all the failing checks. @dominikschubert

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely also test a few of the 1.x versions as well. It would also be great if by default we would limit this as discussed to a set of predefined versions and only execute the full list on-demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants