Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with cdk<2.167.0 #99

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Dec 4, 2024

Fixes a regression introduced in #96 which fixed compatibility with aws-cdk >=2.167.0 but introduced assumptions that were not holding against older AWS CDK versions (e.g. 2.166.0).

Symptom: When running cdklocal it now failed with: Cannot set properties of undefined (setting 'endpoint')

These kind of issues will be prevented in the future by testing against multiple older AWS CDK versions (see #98). In fact this issue here was already discovered via those initial tests!

I'll wait until we have the CI from #98 ready and then potentially have fixed more regressions for even older versions, before publishing an updated version.

@dominikschubert dominikschubert self-assigned this Dec 4, 2024
Copy link

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I have experienced this today!

@dominikschubert dominikschubert merged commit da79f55 into main Dec 5, 2024
12 checks passed
@dominikschubert dominikschubert deleted the fix-backwards-compatibility branch December 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants