Compatibility with AWS-CDK >= 2.167.0 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With https://github.com/aws/aws-cdk/releases/tag/v2.167.0
aws-cdkswitched to the JavaScript AWS SDK v3 which has a completely different way of instantiating and configuring clients. This unfortunately broke the integration with LocalStack as the clients were using their default endpoints (i.e. targeting AWS).Addresses #95
Note: Maintainence here is really getting a bit hard with all the different levels of undefined compatibility for different versions. A lot of the code is completely unnecessary at this point for the latest aws-cdk versions.
Would love to discuss this in the future, but for now this is a quick and easy fix to patch the correct endpoints into the clients/configs.