Fix #find_or_create_professor

[grmnlrt]

Edusign API now returns the following error when we try to find a professor who doesn't exist by email 👇

Error - cannot get professor by email [email protected]

I referenced this error in a new constant in Response::Error::CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE and stoped rising an error when the API return this message.

[Eschults]

👋 @grmnlrt you need to change the condition at the end of L234 otherwise we won't enter the rescue, right?

edusign/lib/edusign/client.rb

Line 234 in 9ba62d2

raise Response::Error, Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE if response.message == "professor not found"

💡 Maybe we could use the existing PROFESSOR_NOT_FOUND_ERROR_MESSAGE instead of adding a new constant?

[ssaunier]

Oops sorry :/

[ssaunier]

@grmnlrt your should be able to re-push on the branch and reopen the PR

[grmnlrt]

I tried it locally with a binding.pry and I was entering the rescue properly🤔

I guess know when we make the request with a wrong email the status return by API is "error"

[grmnlrt]

Just retried locally and the line 234 isn't reached, the error is raise at L233 so I think we should keep it like this

[Eschults]

Right, this line in the api method ensures the raise and rescue, never mind 👌 there might be room for simplification 👉 #11 WDYT ❓