Skip to content

Commit

Permalink
Rescue new error in #find_or_create_professor
Browse files Browse the repository at this point in the history
  • Loading branch information
grmnlrt committed Sep 1, 2023
1 parent 82b1786 commit 9ba62d2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/edusign/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def find_or_create_professor(first_name:, last_name:, email:)

response.result
rescue Response::Error => e
raise e unless [Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message)
raise e unless [Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message) || e.message.include?(Response::Error::CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE)

response = create_professor(first_name: first_name, last_name: last_name, email: email)
response.result
Expand Down Expand Up @@ -286,6 +286,7 @@ class Response
class Error < StandardError
PROFESSOR_NOT_FOUND_ERROR_MESSAGE = "professor not found".freeze
PROFESSOR_DELETED_ERROR_MESSAGE = "professor was deleted".freeze
CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE = "Error - cannot get professor by email".freeze
end

attr_reader :body
Expand Down

0 comments on commit 9ba62d2

Please sign in to comment.