Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DROOLS-7605] WebSphere kie-server-tests fails #3021

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[DROOLS-7605] WebSphere kie-server-tests fails #3021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kie-server-parent/kie-server-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,6 +1253,7 @@
<home>${websphere.home}</home>
<timeout>240000</timeout>
<systemProperties>
<org.kie.server.id>test-kie-server</org.kie.server.id>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very sure if this is the right way to fix. We want to use a test utility class to set the serverId?

Interestingly, this issue doesn't happen with other containers (wildfly, tomcat, weblogic), so probably it has something to do with when serverId should be set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess websphere doesn't execute ServletContextListener on deployment (so Bootstrap mechanism to provide an arbitrary name doesn't work here), but as this parameter is mandatory, it's a good fix.

<org.kie.server.persistence.tm>WebSphere</org.kie.server.persistence.tm>
<org.kie.server.domain>WSLogin</org.kie.server.domain>
<org.kie.executor.jms.cf>jms/cf/KIE.SERVER.EXECUTOR</org.kie.executor.jms.cf>
Expand Down
Loading