Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-7605] WebSphere kie-server-tests fails #3021

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

tkobayas
Copy link
Contributor

JIRA:
https://issues.redhat.com/browse/DROOLS-7605

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@@ -1253,6 +1253,7 @@
<home>${websphere.home}</home>
<timeout>240000</timeout>
<systemProperties>
<org.kie.server.id>test-kie-server</org.kie.server.id>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very sure if this is the right way to fix. We want to use a test utility class to set the serverId?

Interestingly, this issue doesn't happen with other containers (wildfly, tomcat, weblogic), so probably it has something to do with when serverId should be set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess websphere doesn't execute ServletContextListener on deployment (so Bootstrap mechanism to provide an arbitrary name doesn't work here), but as this parameter is mandatory, it's a good fix.

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmunozfe
Copy link
Member

jenkins do fdb

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and worked properly, awesome work @tkobayas !

@@ -1253,6 +1253,7 @@
<home>${websphere.home}</home>
<timeout>240000</timeout>
<systemProperties>
<org.kie.server.id>test-kie-server</org.kie.server.id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess websphere doesn't execute ServletContextListener on deployment (so Bootstrap mechanism to provide an arbitrary name doesn't work here), but as this parameter is mandatory, it's a good fix.

@gmunozfe
Copy link
Member

@tkobayas please add backport labels for 7.67.x and blue

@gmunozfe
Copy link
Member

jenkins do fdb

@tkobayas tkobayas added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jan 30, 2024
@tkobayas
Copy link
Contributor Author

GHA Java 11: Flaky

kiegroup_droolsjbpm-integration/kie-server-parent/kie-server-remote/kie-server-client/src/test/java/org/kie/server/client/LoadBalancerClientTest.java:279 | No available endpoints found

@tkobayas
Copy link
Contributor Author

@mareknovotny Could you please merge this PR? Thanks!

@mareknovotny mareknovotny merged commit e2bdbe4 into kiegroup:main Jan 31, 2024
7 of 9 checks passed
mareknovotny pushed a commit that referenced this pull request Feb 1, 2024
mareknovotny pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants