Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SriovNetwork and SriovIBNetwork controllers to use same code #663

Merged

Conversation

ykulazhenkov
Copy link
Collaborator

Controllers were refactoring to use genericNetworkReconciler, which contains all logic

This is necessary to make it easier to add new controllers.

Controllers were refactoring to use genericNetworkReconciler, which
contains all logicc

Signed-off-by: Yury Kulazhenkov <[email protected]>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8355447020

Details

  • 153 of 189 (80.95%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 37.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/generic_network_controller.go 125 161 77.64%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 70.36%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovnetworknodestate.go 2 48.65%
pkg/daemon/daemon.go 3 48.01%
Totals Coverage Status
Change from base Build 8340797420: -0.2%
Covered Lines: 4789
Relevant Lines: 12722

💛 - Coveralls

@ykulazhenkov
Copy link
Collaborator Author

used by #646

Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, thanks @ykulazhenkov

controllers/generic_network_controller.go Show resolved Hide resolved
@ykulazhenkov
Copy link
Collaborator Author

@zeeke @SchSeba
Could you please review this PR? :)
Thx!

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit f2ca884 into k8snetworkplumbingwg:master Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants