Add OVSNetwork CRD and controller for it #646

ykulazhenkov · 2024-03-05T11:55:14Z

This PR adds OVSNetwork CRD and controller for it.

Context is #640

Depends on: #663. Last two commits to review

github-actions · 2024-03-05T11:55:25Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-05T12:00:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-05T12:13:25Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-03-05T12:18:51Z

Pull Request Test Coverage Report for Build 8893889198

Details

97 of 168 (57.74%) changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 38.86%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/v1/helper.go	45	56	80.36%
api/v1/zz_generated.deepcopy.go	33	93	35.48%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	70.36%

Totals
Change from base Build 8893830201:	0.3%
Covered Lines:	4962
Relevant Lines:	12769

💛 - Coveralls

github-actions · 2024-03-07T08:48:58Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-12T09:20:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-13T14:36:16Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-18T13:17:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-03-20T07:53:08Z

move refactoring commit to a separate PR #663

github-actions · 2024-03-20T08:00:03Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

api/v1/ovsnetwork_types.go

controllers/ovsnetwork_controller.go

github-actions · 2024-03-25T13:43:14Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-02T06:48:55Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-04-02T06:50:27Z

I removed the note about auto bridge selection. PR to the ovs-cni is not merged and this comment is incorrect at the moment

Signed-off-by: Yury Kulazhenkov <[email protected]>

github-actions · 2024-04-30T11:21:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

Great work!

just small nits and we should be able to merge this one

SchSeba · 2024-05-03T15:37:08Z

bindata/manifests/cni-config/ovs/ovs-cni-config.yaml

+    k8s.v1.cni.cncf.io/resourceName: {{.CniResourceName}}
+spec:
+  config: '{
+  "cniVersion":"0.3.1",


please update this one version to also 1.0.0

since yury is on PTO i addressed this in #696

SchSeba · 2024-05-03T15:38:01Z

config/samples/sriovnetwork_v1_ovsnetwork.yaml

@@ -0,0 +1,7 @@
+apiVersion: sriovnetwork.openshift.io/v1


please make a valid example here

since yury is on PTO i addressed this in #696

please note that other samples have the same value. i have aligned this one in the followup pr

adrianchiris

LGTM, @SchSeba PTAL, happy to address additional comments as a followup PR since yury is on PTO

adrianchiris · 2024-05-13T07:56:37Z

@SchSeba can we merge this one ?

SchSeba · 2024-05-13T13:12:05Z

closing this one

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from 96c6cf8 to 062ceda Compare March 5, 2024 12:00

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from 062ceda to 7356cf2 Compare March 5, 2024 12:13

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from 7356cf2 to ed47b49 Compare March 7, 2024 08:48

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from ed47b49 to 1791638 Compare March 12, 2024 09:20

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from 1791638 to f66feeb Compare March 13, 2024 14:36

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from f66feeb to de0caa8 Compare March 18, 2024 13:17

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from de0caa8 to b539265 Compare March 20, 2024 07:59

ykulazhenkov mentioned this pull request Mar 20, 2024

Refactor SriovNetwork and SriovIBNetwork controllers to use same code #663

Merged

e0ne reviewed Mar 25, 2024

View reviewed changes

api/v1/ovsnetwork_types.go Outdated Show resolved Hide resolved

api/v1/ovsnetwork_types.go Show resolved Hide resolved

controllers/ovsnetwork_controller.go Outdated Show resolved Hide resolved

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from b539265 to fb6bd63 Compare March 25, 2024 13:43

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from fb6bd63 to 13ceb25 Compare April 2, 2024 06:48

e0ne approved these changes Apr 8, 2024

View reviewed changes

ykulazhenkov added 2 commits April 30, 2024 14:20

Add OVSNetwork CRD and dummy controller for it

d959004

Signed-off-by: Yury Kulazhenkov <[email protected]>

Add implementation for OVSNetwork controller

dd72472

Signed-off-by: Yury Kulazhenkov <[email protected]>

ykulazhenkov force-pushed the pr-ovsnetwork-controller branch from 13ceb25 to dd72472 Compare April 30, 2024 11:21

SchSeba reviewed May 3, 2024

View reviewed changes

adrianchiris approved these changes May 8, 2024

View reviewed changes

SchSeba mentioned this pull request May 13, 2024

Followup pr 646 #696

Merged

SchSeba closed this May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OVSNetwork CRD and controller for it #646

Add OVSNetwork CRD and controller for it #646

ykulazhenkov commented Mar 5, 2024 •

edited

Loading

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

coveralls commented Mar 5, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Apr 2, 2024

ykulazhenkov commented Apr 2, 2024

github-actions bot commented Apr 30, 2024

SchSeba left a comment

SchSeba May 3, 2024

adrianchiris May 6, 2024

SchSeba May 3, 2024

adrianchiris May 6, 2024

adrianchiris May 8, 2024

adrianchiris left a comment

adrianchiris commented May 13, 2024

SchSeba commented May 13, 2024

Add OVSNetwork CRD and controller for it #646

Add OVSNetwork CRD and controller for it #646

Conversation

ykulazhenkov commented Mar 5, 2024 • edited Loading

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

coveralls commented Mar 5, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8893889198

Details

💛 - Coveralls

github-actions bot commented Mar 7, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Apr 2, 2024

ykulazhenkov commented Apr 2, 2024

github-actions bot commented Apr 30, 2024

SchSeba left a comment

Choose a reason for hiding this comment

SchSeba May 3, 2024

Choose a reason for hiding this comment

adrianchiris May 6, 2024

Choose a reason for hiding this comment

SchSeba May 3, 2024

Choose a reason for hiding this comment

adrianchiris May 6, 2024

Choose a reason for hiding this comment

adrianchiris May 8, 2024

Choose a reason for hiding this comment

adrianchiris left a comment

Choose a reason for hiding this comment

adrianchiris commented May 13, 2024

SchSeba commented May 13, 2024

ykulazhenkov commented Mar 5, 2024 •

edited

Loading

coveralls commented Mar 5, 2024 •

edited

Loading