-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable 'Remember Me' by default [2.0] #2481
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. |
This PR has been closed due to having unresolved merge conflicts. |
Better 🤞 alternative to #1952
Requires jellyfin-archive/jellyfin-apiclient-javascript#154
jellyfin/jellyfin-tizen#51 in short (and interpreted):
User has 2 accounts on the server:
Client is on TV (or any shared device).
When you are logging in via manual form,
Remember Me
is checked by default or restored fromlocalStorage
and you have to disable it for admin/parent account each time other user enabled it.Unset
enableAutoLogin
is treated astrue
, so if you have validAccessToken
, app logs in.When you are logging in via visual form, you cannot turn on/off auto login - its state is taken from previously saved
enableAutoLogin
, i.e. it may be unexpected for user.Changes
Remember Me
is unchecked and not restored - you are presumably starting a new session. And if you want to be remembered you checkRemember Me
once (in opposite to unchecking it each time).Remember Me
is always unchecked. If you have no password, you can easily click your card. With password, you must use manual form (switched automatically). If you want to be "remembered", you can still open the manual form and enable the option.Differences from #1952
Restore previous session
enabled will retain the session cookies, and Jellyfin session will be "remembered" regardless of the user's choice.Issues
Fixes jellyfin/jellyfin-tizen#51
@varlesh also said that
Remember Me
isn't restored from previous state. So there might be alocalStorage
issue, but it works on Tizen 4 and 5 (emulator).