Disable 'Remember Me' by default #1952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
oddstr13
approved these changes
Nov 8, 2020
joshuaboniface
approved these changes
Nov 22, 2020
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media. |
dmitrylyzo
force-pushed
the
forget-me
branch
from
a852d90
to
f143dc3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closed in favor of #2481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jellyfin/jellyfin-tizen#51 in short (and interpreted):
User has 2 accounts on the server:
Client is on TV (or any shared device).
When you are logging in via manual form,
Remember Meis checked by default or restored fromlocalStorageand you have to disable it for admin/parent account each time other user enabled it.Unset
enableAutoLoginis treated astrue, so if you have validAccessToken, app logs in.When you are logging in via visual form, you cannot turn on/off auto login (that's probably why unset
enableAutoLoginis treated astrue). So if no one setRemember Me(via manual form), you will be logged in.Changes
Remember Meis unchecked and not restored - you are presumably starting a new session. And if you want to be remembered you checkRemember Meonce (in opposite to unchecking it each time).enableAutoLoginis treated asfalse.enableAutoLogin, which disables auto login via visual form. If you have no password, you can easily click your card. With password, you must use manual form (switched automatically).Issues
Fixes jellyfin/jellyfin-tizen#51
@varlesh also said that
Remember Meisn't restored from previous state. So there might be alocalStorageissue, but it works on Tizen 4 and 5 (emulator).