Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed url from the WAI sub value, just thumbprint #53

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix: removed url from the WAI sub value, just thumbprint #53

merged 2 commits into from
Jul 6, 2023

Conversation

peppelinux
Copy link
Member

Roland Hedberg rev

  • typo fixed on WAI sub value

@peppelinux peppelinux requested a review from grausof July 6, 2023 08:43
@peppelinux peppelinux marked this pull request as ready for review July 6, 2023 08:43
@peppelinux peppelinux linked an issue Jul 6, 2023 that may be closed by this pull request
Iss in the Wallet Instance Attestation Request should be the same as sub in Response #52
Closed
@peppelinux peppelinux mentioned this pull request Jul 6, 2023
Closed
@balanza
Copy link
Contributor

balanza commented Jul 6, 2023

What was the typo? Sorry, it's difficult to spot it as the whole file appears as changed.

@balanza
Copy link
Contributor

balanza commented Jul 6, 2023

What was the typo? Sorry, it's difficult to spot it as the whole file appears as changed.

Ok I got it.

new old
Thumbprint value of the JWK of the Wallet Instance for which the attestation is being issued. The public url of the issuer concatenated with the thumbprint of the JWK of the Wallet Instance for which the attestation is being issued.

It's more a different specification than a typo, isn't it?

@peppelinux
Copy link
Member Author

What was the typo? Sorry, it's difficult to spot it as the whole file appears as changed.

yes, I just ficed the commit since those "automatic" tables are something messy when something changes within them. Now the PR is more readable, thank you for having pointed this out

@peppelinux
Copy link
Member Author

What was the typo? Sorry, it's difficult to spot it as the whole file appears as changed.

Ok I got it.
new old
Thumbprint value of the JWK of the Wallet Instance for which the attestation is being issued. The public url of the issuer concatenated with the thumbprint of the JWK of the Wallet Instance for which the attestation is being issued.

It's more a different specification than a typo, isn't it?

I'd say that's typo due to a regression happened when we have decided to drop the URL from the sub and use just the thumbprint, but feel free to change the title of this PR

@peppelinux peppelinux changed the title fix: typo fix: removed url from the WAI sub value, just thumbprint Jul 6, 2023
@peppelinux peppelinux merged commit 788af5d into versione-corrente Jul 6, 2023
6 checks passed
@balanza balanza deleted the atttyp1 branch July 6, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grausof grausof grausof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iss in the Wallet Instance Attestation Request should be the same as sub in Response
3 participants
@peppelinux @balanza @grausof