Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss in the Wallet Instance Attestation Request should be the same as sub in Response #52

Closed
rohe opened this issue Jul 6, 2023 · 2 comments · Fixed by #53
Closed

Iss in the Wallet Instance Attestation Request should be the same as sub in Response #52

rohe opened this issue Jul 6, 2023 · 2 comments · Fixed by #53
Assignees
@peppelinux
Milestone
0.5.0

Comments

@rohe
Copy link
Collaborator

rohe commented Jul 6, 2023

iss in the Wallet Instance Attestation Request payload is defined as:
The thumbprint of the JWK of the Wallet Instance or which the attestation is being requested.

In the payload of the Wallet Instance Attestation sub is defined as:
The public url of the issuer concatenated with the thumbprint of the JWK of the Wallet Instance for which the attestation is being issued.

Shouldn't they be the same ?
@peppelinux peppelinux linked a pull request Jul 6, 2023 that will close this issue
fix: removed url from the WAI sub value, just thumbprint #53
Merged
@peppelinux
Copy link
Member

Thank you Roland, fixed here: #53

@peppelinux peppelinux self-assigned this Jul 6, 2023
@peppelinux peppelinux added this to the 0.5.0 milestone Jul 6, 2023
@peppelinux
Copy link
Member

done here #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppelinux peppelinux

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

fix: removed url from the WAI sub value, just thumbprint italia/eudi-wallet-it-docs
2 participants
@rohe @peppelinux