Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial change in Wallet Solution 'alg' HEADER #286

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/en/wallet-solution.rst
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Header
* - **Key**
- **Value**
* - alg
- Algorithm used to verify the token signature. It MUST be one of the possibile values indicated `here <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256).
- Algorithm used to verify the token signature. It MUST be one of the possibile values indicated here [here](https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html) (e.g., ES256).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the RST href while the one your proposing here is the Markdown href type

* - kid
- Thumbprint of the public key used for signing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Thumbprint of the public key used for signing.
- Thumbprint of the public key used for signing, according to [RFC 7638](https://www.rfc-editor.org/rfc/rfc7638.html]

please check that RFC 7638 is in the referenced standard and then use the rst ref pointing to standards.rst rfc 7638 instead of the markdown href

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, RFC 7638 is present in docs/common/standards.rst. I'll edit the sentence as you requested

* - typ
Expand Down
Loading