Editorial change in Wallet Solution 'alg' HEADER #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
requested changes
May 23, 2024
docs/en/wallet-solution.rst
Outdated
| @@ -92,7 +92,7 @@ Header | |||
| * - **Key** | |||
| - **Value** | |||
| * - alg | |||
| - Algorithm used to verify the token signature. It MUST be one of the possibile values indicated `here <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256). | |||
| - Algorithm used to verify the token signature. It MUST be one of the possibile values indicated here [here](https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html) (e.g., ES256). | |||
There was a problem hiding this comment.
this was the RST href while the one your proposing here is the Markdown href type
change from markdown hyperlink form to RST hyperlink form
changed the hyperlink word from *here* to *table*
peppelinux
reviewed
May 27, 2024
| * - **Key** | ||
| - **Value** | ||
| * - alg | ||
| - Algorithm used to verify the token signature. It MUST be one of the possibile values indicated in this `table <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256). |
There was a problem hiding this comment.
Suggested change
| - Algorithm used to verify the token signature. It MUST be one of the possibile values indicated in this `table <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256). | |
| - Algorithm used to verify the token signature. It MUST be one of the values included in this `table <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256). |
peppelinux
requested changes
May 27, 2024
docs/en/wallet-solution.rst
Outdated
| * - alg | ||
| - Algorithm used to verify the token signature. It MUST be one of the possibile values indicated in this `table <https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/algorithms.html>`_ (e.g., ES256). | ||
| * - kid | ||
| - Thumbprint of the public key used for signing. |
There was a problem hiding this comment.
Suggested change
| - Thumbprint of the public key used for signing. | |
| - Thumbprint of the public key used for signing, according to [RFC 7638](https://www.rfc-editor.org/rfc/rfc7638.html] |
please check that RFC 7638 is in the referenced standard and then use the rst ref pointing to standards.rst rfc 7638 instead of the markdown href
There was a problem hiding this comment.
Yes, RFC 7638 is present in docs/common/standards.rst. I'll edit the sentence as you requested
added RCF reference from standards.rst
peppelinux
approved these changes
May 29, 2024
grausof
approved these changes
May 29, 2024
fmarino-ipzs
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve issue #254
Editorial change in Wallet Solution 'alg' HEADER