Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Changes to vec/swizzle implementation #14789

Draft
wants to merge 87 commits into
base: sycl
Choose a base branch
from
Draft

[SYCL] Changes to vec/swizzle implementation #14789

wants to merge 87 commits into from

Commits on Jul 30, 2024

  1. [SYCL] Refactor vec/swizzle implementations, remove expression trees

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1617c6c View commit details
    Browse the repository at this point in the history

  2. Optimized non-bool/non-logical unary ops

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5513578 View commit details
    Browse the repository at this point in the history

  3. Some optimized logical binops

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    43eb8ae View commit details
    Browse the repository at this point in the history

  4. Don't include vector_traits.hpp

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6d33c7a View commit details
    Browse the repository at this point in the history

  5. Include bfloat16 in not_fp check

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    621f4a8 View commit details
    Browse the repository at this point in the history

  6. More comments

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d517b89 View commit details
    Browse the repository at this point in the history

  7. Add Steffen's test, fix a bug it uncovered

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d61241f View commit details
    Browse the repository at this point in the history

  8. Test for repeated indices, remove "preview" REQUIRE

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4a6d061 View commit details
    Browse the repository at this point in the history

  9. Remove stale TODO

    @aelovikov-intel
    aelovikov-intel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4e16cb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. copy-assignment for swizzle

    @aelovikov-intel
    aelovikov-intel committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b3889ed View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. [[maybe_unused]] for an old buggy gcc

    @aelovikov-intel
    aelovikov-intel committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5db502c View commit details
    Browse the repository at this point in the history

  2. Disable swizzle->vec conversion for 1-elem swizzles 

    That's what the specification requires.
    @aelovikov-intel
    aelovikov-intel committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    481050f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Update sycl/include/sycl/vector.hpp 

    Co-authored-by: rolandschulz <[email protected]>
    @aelovikov-intel @rolandschulz
    aelovikov-intel and rolandschulz authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    897f1f9 View commit details
    Browse the repository at this point in the history

  2. ConversionOperatorMixin generalization 

    That might allow easier experiments with the availability of conversion
operators.
    @aelovikov-intel
    aelovikov-intel committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1d28057 View commit details
    Browse the repository at this point in the history

  3. [NFCI][SYCL] Simplify implementation of vec's variadic ctor

    @aelovikov-intel
    aelovikov-intel committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b6ba6cd View commit details
    Browse the repository at this point in the history

  4. [SYCL] sycl::vec::operator= changes 

    * Remove non-standard `sycl::vec::operator=(const different_vec &)`

  Builtins `sycl::abs` and `sycl::abs_diff` have been returning signed
  types for quite some time now, so the change in the test is valid.

* Make `sycl::vec::operator=(const Data &)` non-template

* Add `sycl::vec::operator=(const swizzle &)`
    @aelovikov-intel
    aelovikov-intel committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e0791f9 View commit details
    Browse the repository at this point in the history

  5. [SYCL] XYZW/RGBA/INDEX_ACCESS swizzles should return swizzles 

    Previously these interfaces were returning referencing to the vector
elements which isn't compliant with the specification.
    @aelovikov-intel
    aelovikov-intel committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9dce6df View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    4a3d546 View commit details
    Browse the repository at this point in the history

  2. Try to fix CUDA build

    @aelovikov-intel
    aelovikov-intel committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    11755e8 View commit details
    Browse the repository at this point in the history

  3. Fixes for E2E failures

    @aelovikov-intel
    aelovikov-intel committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    dc43ebc View commit details
    Browse the repository at this point in the history

  4. Fix CI failure on Win

    @aelovikov-intel
    aelovikov-intel committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ad3c303 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Restrict variadic vec ctor to N > 1

    @aelovikov-intel
    aelovikov-intel committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    328bb8f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    74c8b80 View commit details
    Browse the repository at this point in the history

  2. "untemplate" vec::operator vector_t()

    @aelovikov-intel
    aelovikov-intel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    05050bb View commit details
    Browse the repository at this point in the history

  3. clang-format

    @aelovikov-intel
    aelovikov-intel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9c38066 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Address review feedback

    @aelovikov-intel
    aelovikov-intel committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    072a9f4 View commit details
    Browse the repository at this point in the history

  2. Add an option to make ConversionOperatorMixin provide explicit conv… 

    …ersion
    @aelovikov-intel
    aelovikov-intel committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f4d722c View commit details
    Browse the repository at this point in the history

  3. Move vec::convert into sycl/detail/vector_convert.hpp 

    Inverts the dependency between `vector.hpp` and `detail/vector_convert.hpp`
    @aelovikov-intel
    aelovikov-intel committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c96c0c7 View commit details
    Browse the repository at this point in the history

  4. Standalone sycl/vector.hpp

    @aelovikov-intel
    aelovikov-intel committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    762e678 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Infrastructure to make one-eleme swizzles return scalars

    @aelovikov-intel
    aelovikov-intel committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    238bf86 View commit details
    Browse the repository at this point in the history

  2. Infrastructure to limit some of the binop mixins

    @aelovikov-intel
    aelovikov-intel committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    f546f21 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Remove detail/vector_traits.hpp - not used anymore

    @aelovikov-intel
    aelovikov-intel committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    682e614 View commit details
    Browse the repository at this point in the history

  2. __SYCL_VEC_STANDALONE for sycl::half

    @aelovikov-intel
    aelovikov-intel committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e1b882c View commit details
    Browse the repository at this point in the history

  3. Remove non-standard vec::operator=(swizzle) 

    Not really needed
    @aelovikov-intel
    aelovikov-intel committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ed6752b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Explicit operator vector_t + limit hidden friends to N > 1

    @aelovikov-intel
    aelovikov-intel committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    dd6e085 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/sycl' into HEAD 

    # Conflicts:
#	sycl/test/check_device_code/vector/vector_math_ops.cpp
    @aelovikov-intel
    aelovikov-intel committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8eeb60d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. clang-format

    @aelovikov-intel
    aelovikov-intel committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    9722abe View commit details
    Browse the repository at this point in the history

  2. Improve is_op_available

    @aelovikov-intel
    aelovikov-intel committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    9c51ef8 View commit details
    Browse the repository at this point in the history

  3. Use bool Enable in binop mixins

    @aelovikov-intel
    aelovikov-intel committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    fc4bf0a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Minor changes to mixins

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    554e6c0 View commit details
    Browse the repository at this point in the history

  2. Fix element type constraint on template swizzle ops

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    529e4e7 View commit details
    Browse the repository at this point in the history

  3. Remove VecT from swizzle template op mixins

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bb4fa54 View commit details
    Browse the repository at this point in the history

  4. is_assignable_swizzle -> has_repeating_indexes and inline is_const

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2bec5bd View commit details
    Browse the repository at this point in the history

  5. Remove vec from ADL for swizzles

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ad31096 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1eb65f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Big mixin refactor

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    374b125 View commit details
    Browse the repository at this point in the history

  2. Fix a bug

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f017dd7 View commit details
    Browse the repository at this point in the history

  3. WIP last changes, vec full + partial swizzle

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5619dd1 View commit details
    Browse the repository at this point in the history

  4. WIP last changes, part 2

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    52cdb80 View commit details
    Browse the repository at this point in the history

  5. WIP

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f1da047 View commit details
    Browse the repository at this point in the history

  6. Another WIP

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8401dc7 View commit details
    Browse the repository at this point in the history

  7. Some fixes

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    eca85a1 View commit details
    Browse the repository at this point in the history

  8. math builtins fix

    @aelovikov-intel
    aelovikov-intel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    66f521e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. WIP

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9c70691 View commit details
    Browse the repository at this point in the history

  2. Revert sycl/test-e2e/Regression/vec_rel_swizzle_ops.cpp changes

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6151948 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1455856 View commit details
    Browse the repository at this point in the history

  4. Revert some of the earlier tests' changes

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    84b15e8 View commit details
    Browse the repository at this point in the history

  5. Revert/simplify now unnecessary changes in headers

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5ef87a4 View commit details
    Browse the repository at this point in the history

  6. Revert sycl/include/sycl/detail/spirv.hpp changes 

    Maybe it makes sense to re-land them separately for code readability...
    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9368c71 View commit details
    Browse the repository at this point in the history

  7. More reverts/simplifications in e2e

    @aelovikov-intel
    aelovikov-intel committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    762cf75 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    82382e2 View commit details
    Browse the repository at this point in the history

  2. WIP experiments + extra restriction on operator bool

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    506e065 View commit details
    Browse the repository at this point in the history

  3. Regenerate check_device_code CHECKs

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c434bd7 View commit details
    Browse the repository at this point in the history

  4. Revert some changes in stream.hpp

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fd0be88 View commit details
    Browse the repository at this point in the history

  5. Revert changes in sycl/test/basic_tests/vectors/vectors.cpp

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    068c1e9 View commit details
    Browse the repository at this point in the history

  6. Fix tests with multi_ptr's operator+ ambiguity

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a75e9a1 View commit details
    Browse the repository at this point in the history

  7. Fix failing test

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8f2c3aa View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c7b14bd View commit details
    Browse the repository at this point in the history

  9. Regenerated CHECKs

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2786937 View commit details
    Browse the repository at this point in the history

  10. is_explicitly_convertible and remove operator bool

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0485c8f View commit details
    Browse the repository at this point in the history

  11. Fix for multi_ptr's operator+

    @aelovikov-intel
    aelovikov-intel committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c2f9fe7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e96adef View commit details
    Browse the repository at this point in the history

  2. from_incomplete without uses

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3182a68 View commit details
    Browse the repository at this point in the history

  3. WIP

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7f7b69b View commit details
    Browse the repository at this point in the history

  4. is_op_available<Self, Op>

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3f13f11 View commit details
    Browse the repository at this point in the history

  5. WIP2

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c2e3524 View commit details
    Browse the repository at this point in the history

  6. WIP3

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7caf4e0 View commit details
    Browse the repository at this point in the history

  7. WIP4

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9e767fb View commit details
    Browse the repository at this point in the history

  8. WIP5

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f2d808f View commit details
    Browse the repository at this point in the history

  9. Another WIP

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e11ff45 View commit details
    Browse the repository at this point in the history

  10. Simplify SwizzleBase's template parameters

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4501bc1 View commit details
    Browse the repository at this point in the history

  11. Add EBO static_assert

    @aelovikov-intel
    aelovikov-intel committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fcb8899 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Workaround MSVC bug: https://godbolt.org/z/bMdn3hWds

    @aelovikov-intel
    aelovikov-intel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7d4b83f View commit details
    Browse the repository at this point in the history

  2. Fix failing e2e tests (single source)

    @aelovikov-intel
    aelovikov-intel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7a3d644 View commit details
    Browse the repository at this point in the history

  3. scalar named swizzles

    @aelovikov-intel
    aelovikov-intel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    280bbb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge remote-tracking branch 'origin/sycl' into HEAD

    @aelovikov-intel
    aelovikov-intel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dc9d597 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. vector_t WIP change

    @aelovikov-intel
    aelovikov-intel committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5ebc90c View commit details
    Browse the repository at this point in the history