-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Changes to vec/swizzle implementation #14789
Draft
aelovikov-intel
wants to merge
87
commits into
intel:sycl
Choose a base branch
from
aelovikov-intel:new-swizzle
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 03:40
— with
GitHub Actions
Failure
This comment was marked as outdated.
This comment was marked as outdated.
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 04:15
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 17:06
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 18:32
— with
GitHub Actions
Failure
aelovikov-intel
changed the title
[SYCL] Refactor swizzle implementation, remove expression trees
[SYCL] Refactor vec/swizzle implementation, remove expression trees
Jul 26, 2024
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 23:11
— with
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 23:25
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 26, 2024 23:56
— with
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
new-swizzle
branch
from
July 29, 2024 20:03
76aa490
to
83c08b4
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 29, 2024 20:04
— with
GitHub Actions
Error
aelovikov-intel
force-pushed
the
new-swizzle
branch
from
July 29, 2024 20:50
83c08b4
to
de19046
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 29, 2024 20:51
— with
GitHub Actions
Error
aelovikov-intel
force-pushed
the
new-swizzle
branch
from
July 29, 2024 20:52
de19046
to
9f163f6
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 29, 2024 20:53
— with
GitHub Actions
Error
aelovikov-intel
force-pushed
the
new-swizzle
branch
from
July 29, 2024 20:59
9f163f6
to
2f566b8
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
July 29, 2024 21:00
— with
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
July 29, 2024 22:23
— with
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
July 30, 2024 00:37
— with
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
new-swizzle
branch
from
July 30, 2024 02:26
c2d18bf
to
60898fc
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
July 30, 2024 02:27
— with
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
July 30, 2024 02:30
— with
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
July 30, 2024 03:10
— with
GitHub Actions
Inactive
This comment was marked as outdated.
This comment was marked as outdated.
aelovikov-intel
commented
Jul 30, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
August 23, 2024 18:05
— with
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 23, 2024 18:44
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 23, 2024 23:35
— with
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 23, 2024 23:55
— with
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 23, 2024 23:59
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 24, 2024 00:33
— with
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
August 26, 2024 18:17
— with
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 26, 2024 19:05
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 26, 2024 22:31
— with
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
August 26, 2024 23:05
— with
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
August 27, 2024 15:43
— with
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
August 27, 2024 17:07
— with
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
September 4, 2024 22:18
— with
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
September 4, 2024 23:12
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.x()/.r()/etc.
) return a swizzle vs previously returned reference to a scalarsycl::vec
and swizzles (named swizzles and multiple binary/unary/op-assign operators)vec::(const ArgTys... &args)
ctorDeviations from the specifications added as part of this PR:
vec::(const ArgTys... &args)
ctor - add an additionalNumElements > 1
requirement to resolve the following ambiguity otherwise present with the currentis_convertible
implementation (a pre-existing deviation from the spec, see below):Other known remaining differences from the specification inherited from the previous implementation:
vec::(const ArgTys... &args)
ctor requirements have been weaker (std::is_convertible_v<T, DataT>
) than required by the specification (must be an exact match of the element_type). Also, unlike the specification, it allowsargs
to be swizzles (in addition to scalars andvec
s).vec(const vector_t &)
ctor is still templated to avoid ambiguity withvec(const DataT &)
for one-element vectorsstd::byte
support, in particular how some hidden friend operators aren't available and non-standard shift operators are implemented instead, e.g.operator<<(const Self &, int)
Newly added test is mostly copied from @steffenlarsen 's #13026.