[SYCL] Remove plugin interface #14145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kbenzie
changed the title
kbenzie
added
the
abi-break
Also fix discarded result for mem allocations, and finish device global handling
This was mostly done anyway.
|
@intel/llvm-gatekeepers please merge |
sarnex
pushed a commit
that referenced
this pull request
Jul 29, 2024
#14145 added, moved, and removed files owned by the `unified-runtime-reviewers` team. This patch updates the CODEOWNERS file accordingly.
This was referenced Aug 2, 2024
Closed
| /// | ||
| /// \ingroup sycl_pi | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
This file was being included in at least one external software, the open-source oneMKL Interfaces project, which breaks after removal of this file. Can someone please comment why this PR is not marked as a breaking change unlike some others? Also, it would help to know what the fix would be to oneMKL Interfaces here to prevent errors like:
/export/users/gchoudha/oneMKL-interfaces/src/blas/backends/cublas/cublas_scope_handle.hpp:31:10: fatal error: 'sycl/detail/pi.hpp' file not found
31 | #include <sycl/detail/pi.hpp>
| ^~~~~~~~~~~~~~~~~~~~
1 error generated.
There was a problem hiding this comment.
pi.hpp is an undocumented header which is not a part of our public API and we do not guarantee stability of internal APIs.
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 24, 2024
This is a by-product of intel#14145. Functions to dynamically load a library and query a symbol out of it should not be attached to UR, because they are used for other libraries as well. Moved them from `detail::ur` into `detail` namespace, outlined into a separate header and removed declarations from public SYCL headers. Fixes intel#14923
steffenlarsen
pushed a commit
that referenced
this pull request
Oct 7, 2024
These e2e tests started failing after PI removal and replacing it with UR ([PR](#14145)) However, they were not related to it. On Windows, dlls unloading is inconsistent and if we try to release these UR objects manually, inconsistent hangs happen due to a race between unloading the UR adapters dlls (in addition to their dependency dlls) and the releasing of these UR objects (The proxy loader have solved this problem partially [here](#15262)). So, we currently shutdown without releasing them and windows should handle the memory cleanup. This behaviour is the same old behaviour as before removing PI as on Investigations on this. This was only hidden before PI removal as it was calling the PI entry-point but doesn't make it to UR entry-point and Filecheck logs check for objects release would pass as it only check for the call to the PI entry-point without check that the call was a successful call. That was the PI call for `piContextRelease` before PI removal: ``` ---> piContextRelease( <unknown> : 0000023CC0EBA6C0 ) ---> API Called After Plugin Teardown, Functon Call ignored. ``` Fixes #14768 Fixes #14950 Fixes #14968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.