Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move loadOsLibrary and unloadOsLibrary to os_util. #14923

Open
Tracked by #14598
aarongreig opened this issue Aug 2, 2024 · 1 comment · May be fixed by #15491
Open
Tracked by #14598

move loadOsLibrary and unloadOsLibrary to os_util. #14923

aarongreig opened this issue Aug 2, 2024 · 1 comment · May be fixed by #15491
Labels
pi-port

Comments

@aarongreig
Copy link
Contributor

aarongreig commented Aug 2, 2024 •
edited
Loading

based on this comment #14145 (comment)
@aarongreig aarongreig mentioned this issue Aug 2, 2024
Open
@aarongreig aarongreig changed the title move loadOsLibrary and unloadOsLibrary to os_util. mentioned here move loadOsLibrary and unloadOsLibrary to os_util. Aug 2, 2024
@aarongreig
Copy link
Contributor Author

addressed by #14791

@aarongreig aarongreig mentioned this issue Aug 2, 2024
Closed
AlexeySachkov added a commit to AlexeySachkov/llvm that referenced this issue Sep 24, 2024
@AlexeySachkov
[SYCL][NFC] Detach library loading helpers from UR
ef9ae8e 
This is a by-product of intel#14145. Functions to dynamically load a library and
query a symbol out of it should not be attached to UR, because they are used for
other libraries as well.

Moved them from `detail::ur` into `detail` namespace, outlined into a separate
header and removed declarations from public SYCL headers.

Fixes intel#14923
@AlexeySachkov AlexeySachkov linked a pull request Sep 24, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pi-port
Projects
None yet
Milestone
No milestone
1 participant
@aarongreig