Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions for circuit builds and e2e tests #30

Merged
merged 30 commits into from
Aug 12, 2024
Merged

Conversation

jimthematrix
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.74%. Comparing base (839bf5b) to head (34b0372).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
+ Coverage   45.37%   55.74%   +10.37%     
===========================================
  Files          16       16               
  Lines         540      540               
===========================================
+ Hits          245      301       +56     
+ Misses        253      198       -55     
+ Partials       42       41        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only comment is the e2e run takes around 10 mins. But we can evaluate the impact of it going forward.

@jimthematrix
Copy link
Contributor Author

Indeed. we probably should figure out a "PR unit tests bucket" that includes only the unit tests, and an "e2e" tests bucket that gets run only for the PR merge build

@jimthematrix jimthematrix merged commit 6544a70 into main Aug 12, 2024
7 checks passed
@jimthematrix jimthematrix deleted the gh-actions branch August 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants