Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key mgmt library and create a top-level sparse-merkle-tree library #26

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

jimthematrix
Copy link
Contributor

  • moved the sparse merkle tree implementation code to a top-level package sparse-merkle-tree
  • started a new top-level package keys to demonstrate usage of existing encrypted keys capabilities for the Babyjubjub curve

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.74%. Comparing base (39bd365) to head (f857524).

Files Patch % Lines
zkp/golang/pkg/key-manager/key/key-manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   45.09%   45.74%   +0.64%     
==========================================
  Files          14       16       +2     
  Lines         530      540      +10     
==========================================
+ Hits          239      247       +8     
- Misses        250      252       +2     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PublicKey: privKey.Public(),
PrivateKeyForZkp: privKeyForZkp,
}
}
Copy link
Contributor

@Chengxuan Chengxuan Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimthematrix I think we should just replace the key-manager.go under pkg directory with this file for now along with its test.

Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key manager itself looks good to me, test coverage dropped so will need to be addressed. One solution is to combine the key-manager in internal package with the one in pkg package.

@jimthematrix feel free to address that in #25 if that makes things easier on your side.

@jimthematrix
Copy link
Contributor Author

jimthematrix commented Aug 6, 2024

thanks for the review @Chengxuan. there's coverage in the integration-test/e2e.go that's not counted because we don't have all the steps to set up the e2e test. I'm hoping once we have implemented #29 the coverage will improve (like here: #30)

@jimthematrix jimthematrix merged commit 1c7f4a7 into main Aug 6, 2024
5 checks passed
@jimthematrix jimthematrix deleted the key-mgmt branch August 6, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants