Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: windows native error & obfuscation support #2286

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 63 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
be5f950
chore: update windows code based on latest flutter template with plug…
vaind Jun 10, 2024
f88531c
feat: add sentry-native library to the windows build
vaind Aug 21, 2024
4341827
add sentry-native bindings
vaind Aug 22, 2024
588c047
basic tests
vaind Aug 22, 2024
4fea4b9
more native binding functions
vaind Aug 22, 2024
cac80c3
improve native tests
vaind Aug 26, 2024
dd8d1e6
more native binding calls
vaind Aug 26, 2024
50fd16c
load debug image list
vaind Aug 26, 2024
852a306
add native feature support flags
vaind Aug 26, 2024
db797f9
clean
vaind Aug 26, 2024
98c7913
Merge branch 'main' into feat/windows-native
vaind Aug 26, 2024
9a82b38
update native crash example
vaind Aug 26, 2024
e2e2841
Merge branch 'main' into feat/windows-native
vaind Sep 4, 2024
cede7cd
post-merge fixup
vaind Sep 6, 2024
bdedccf
example: allways show console in the windows sample app
vaind Sep 7, 2024
0d07f97
fix: windows build with crashpad
vaind Sep 7, 2024
0ff707b
update test script
vaind Sep 7, 2024
e258718
tmp
vaind Sep 9, 2024
8fc78fd
tmp
vaind Sep 9, 2024
6cb6c2b
tmp
vaind Sep 9, 2024
4e9da9e
remove cmake_minimum_required
vaind Sep 9, 2024
00692fc
windows native obfuscated stack trace support
vaind Sep 11, 2024
f70dbbb
move native debug image resolution to sentry_native.dart
vaind Sep 12, 2024
7ab7ff0
fix native test setup
vaind Sep 12, 2024
b516961
further improve native test build
vaind Sep 12, 2024
9a7f1a9
update debug id conversion code
vaind Sep 12, 2024
9fb0c2a
fix native init test
vaind Sep 12, 2024
5cb2338
Merge branch 'main' into feat/windows-native
vaind Sep 12, 2024
2f093db
test fixes
vaind Sep 12, 2024
25b4007
Merge branch 'main' into feat/windows-native
vaind Sep 16, 2024
5456fac
cleanup
vaind Sep 16, 2024
52554a9
Merge branch 'main' into feat/windows-native
vaind Sep 16, 2024
4c6ddd0
improve native test
vaind Sep 16, 2024
ab4d095
ensure crashpad_wer is distributed
vaind Sep 16, 2024
b30ed39
post-merge failing test fixes
vaind Sep 16, 2024
0098c63
move stacktrace parsing back to stacktrace factory
vaind Sep 17, 2024
d2ee5ac
fix debug image integration and tests
vaind Sep 18, 2024
1c7b63d
tmp: use sentry.init in the flutter example
vaind Sep 18, 2024
c4178c7
fixup dart deps
vaind Sep 18, 2024
490c049
comment fix
vaind Sep 18, 2024
1d648a3
rename: SentryStackTraceFactory create() to parse()
vaind Sep 18, 2024
b5dcd2a
linter isssues
vaind Sep 18, 2024
3f85fc1
analyzer issue
vaind Sep 18, 2024
607b382
fix tests on web
vaind Sep 18, 2024
2de3fc6
fixup code coverage test
vaind Sep 18, 2024
bd69052
chore: update stacktrace tests
vaind Sep 18, 2024
0c92e29
fix missing deps
vaind Sep 18, 2024
b0aa3ab
formatting
vaind Sep 18, 2024
fd2d073
add missing override annotations
vaind Sep 18, 2024
f9a3b73
merge sentry-native debug image creation to dart
vaind Sep 18, 2024
42a868c
analyzer issues
vaind Sep 18, 2024
575de3f
disable analysis on generated code
vaind Sep 18, 2024
1a2cc39
Merge branch 'main' into feat/windows-native
vaind Sep 18, 2024
315b576
chore: update changelog
vaind Sep 18, 2024
d63e654
analyzer issues
vaind Sep 19, 2024
7e13929
fix tests
vaind Sep 19, 2024
4701791
Revert "tmp: use sentry.init in the flutter example"
vaind Sep 20, 2024
5136aaa
Merge branch 'main' into feat/windows-native
vaind Sep 24, 2024
5fa09e2
test: fix flutter test
vaind Sep 25, 2024
ed1b2b8
Merge branch 'main' into feat/windows-native
vaind Sep 25, 2024
60c3d9e
Merge branch 'main' into feat/windows-native
vaind Sep 26, 2024
cf9b045
Merge branch 'main' into feat/windows-native
vaind Oct 2, 2024
2eb5d8a
Merge branch 'main' into feat/windows-native
vaind Oct 7, 2024
72547cf
fix int.toNativeValue() range
vaind Oct 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/flutter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,16 @@ jobs:
with:
name: sentry_flutter
file: ./flutter/coverage/lcov.info
functionalities: "search" # remove after https://github.com/codecov/codecov-action/issues/600
functionalities: 'search' # remove after https://github.com/codecov/codecov-action/issues/600
token: ${{ secrets.CODECOV_TOKEN }}

- uses: VeryGoodOpenSource/very_good_coverage@c953fca3e24a915e111cc6f55f03f756dcb3964c # [email protected]
if: matrix.sdk == 'stable' && matrix.target == 'linux'
with:
path: './flutter/coverage/lcov.info'
min_coverage: 90
exclude: 'lib/src/native/cocoa/binding.dart'
# 'native/c' for now because we run coverage on Linux where these are not tested yet.
exclude: 'lib/src/native/cocoa/binding.dart lib/src/native/c/*'

- name: Build ${{ matrix.target }}
working-directory: flutter/example
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Update Dependencies
on:
# Run every day.
schedule:
- cron: "0 3 * * *"
- cron: '0 3 * * *'
# And on on every PR merge so we get the updated dependencies ASAP, and to make sure the changelog doesn't conflict.
push:
branches:
Expand All @@ -27,6 +27,14 @@ jobs:
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

native:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-native.sh
name: Native SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

metrics-flutter:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
### Features

- Emit `transaction.data` inside `contexts.trace.data` ([#2284](https://github.com/getsentry/sentry-dart/pull/2284))
- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291))
- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291)
- Windows native error & obfuscation support ([#2286](https://github.com/getsentry/sentry-dart/pull/2286))

### Enhancements

Expand Down
195 changes: 0 additions & 195 deletions dart/lib/src/debug_image_extractor.dart

This file was deleted.

Loading
Loading