feat: windows native error & obfuscation support #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vaind
force-pushed
the
feat/windows-native
branch
from
9766931
to
fd2d073
Compare
This reverts commit 1c7b63d.
vaind
requested review from
krystofwoldrich,
stefanosiano and
martinhaintz
as code owners
3 tasks
buenaflor
reviewed
Oct 7, 2024
| @@ -91,6 +91,7 @@ class SentryStackFrame { | |||
| /// The "package" the frame was contained in. | |||
| final String? package; | |||
|
|
|||
| // TODO what is this? doesn't seem to be part of the spec https://develop.sentry.dev/sdk/event-payloads/stacktrace/ | |||
| final bool? native; | |||
There was a problem hiding this comment.
hm not sure if this is even used in the sentry product
buenaflor
reviewed
Oct 8, 2024
| extension on String { | ||
| binding.sentry_value_u toNativeValue() { | ||
| final cValue = toNativeUtf8(); | ||
| final result = SentryNative.native.value_new_string(cValue.cast()); |
There was a problem hiding this comment.
is there a chance when cValue.cast() throws an exception that cValue is never freed?
There was a problem hiding this comment.
I don't believe cast() can throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This adds support for:
💡 Motivation and Context
split-debug-infofor Flutter Desktop (Linux and Windows) #433💚 How did you test it?
Added tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps