Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Directory Service - change settings init to deep copy #8434

Merged
merged 2 commits into from
Dec 25, 2024
+2 −1
Merged

[Bug Fix] Directory Service - change settings init to deep copy #8434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f494349
change settings to deep copy
zkarpinski Dec 24, 2024
497f307
Merge branch 'getmoto:master' into ds-fix-settings-copy
zkarpinski Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion moto/ds/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""DirectoryServiceBackend class with methods for supported APIs."""

import copy
from typing import Any, Dict, List, Optional, Tuple

from moto.core.base_backend import BackendDict, BaseBackend
Expand Down Expand Up @@ -141,7 +142,7 @@ def __init__(
self.ldaps_settings_info: List[LdapsSettingInfo] = []
self.trusts: List[Trust] = []
self.settings = (
SETTINGS_ENTRIES_MODEL.copy()
copy.deepcopy(SETTINGS_ENTRIES_MODEL)
if self.directory_type == "MicrosoftAD"
else []
)
Expand Down
Loading