[Bug Fix] Directory Service - change settings init to deep copy

[zkarpinski]

The Settings list of dictionaries is a shadow copy, resulting in unexpected results when there are 2+ directories with changed settings.

A deep copy resolves this issue.

[bblommers]

Can you merge in the latest master @zkarpinski? That should fix the build - happy to merge afterwards

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (4bfdfaf) to head (497f307).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8434   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1168     1168           
  Lines      101701   101702    +1     
=======================================
+ Hits        96214    96215    +1     
  Misses       5487     5487           

Flag	Coverage Δ
servertests	28.82% <100.00%> (+<0.01%)	⬆️
unittests	94.57% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bblommers]

Great, thank you!