Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed workflow to prevent terraform tests from failing #8428

Merged
merged 2 commits into from
Dec 22, 2024
Merged

chore: Fixed workflow to prevent terraform tests from failing #8428

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ab2cd
chore: pinning GitHub Actions runner version for Terraform test
cm-iwata Dec 22, 2024
e93f3f2
chore: revert explicitly specify GitHub Actions runner version
cm-iwata Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests_terraform_examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
echo "folders=$folders" >> $GITHUB_OUTPUT

test:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick - but can we keep this as latest? Just to prevent future maintenance 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If use the latest label, there is a risk that tests will suddenly fail one day due to compatibility issues.
That's why I explicitly specified runner version in this PR.

However, if compatibility is maintained when upgrading Runner, as you say, unnecessary maintenance will occur when upgrading.

Both approaches have advantages and disadvantages, but I think it's better to follow a unified policy across the project, so we I modified it to use latest.

e93f3f2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

needs: find-jobs
strategy:
fail-fast: false
Expand All @@ -44,6 +44,8 @@ jobs:
python -m build
docker run --rm -t --name motoserver -e TEST_SERVER_MODE=true -e AWS_SECRET_ACCESS_KEY=server_secret -e AWS_ACCESS_KEY_ID=server_key -v `pwd`:/moto -p 5000:5000 -v /var/run/docker.sock:/var/run/docker.sock python:3.10-slim /moto/scripts/ci_moto_server.sh &
python scripts/ci_wait_for_server.py
- name: Set up Terraform
uses: hashicorp/setup-terraform@v3
- name: Run tests
if: ${{ matrix.service != 'rds' }}
run: |
Expand Down
Loading