Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed workflow to prevent terraform tests from failing #8428

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

cm-iwata
Copy link
Contributor

@cm-iwata cm-iwata commented Dec 22, 2024

Currently, ubuntu-latest is specified as the Runner in Git Hub Actions, but ubuntu-latest will soon be changed to point to ubuntu-24.04.

The ubuntu-24.04 Runner does not have a built-in Terraform command, so terraform tests will suddenly fail one day.

I used a forked repository to perform the following tests.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (db93058) to head (e93f3f2).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8428   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1163     1163           
  Lines      101638   101639    +1     
=======================================
+ Hits        96152    96153    +1     
  Misses       5486     5486           
Flag Coverage Δ
servertests 28.84% <ø> (-0.01%) ⬇️
unittests 94.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -23,7 +23,7 @@ jobs:
echo "folders=$folders" >> $GITHUB_OUTPUT

test:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick - but can we keep this as latest? Just to prevent future maintenance 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If use the latest label, there is a risk that tests will suddenly fail one day due to compatibility issues.
That's why I explicitly specified runner version in this PR.

However, if compatibility is maintained when upgrading Runner, as you say, unnecessary maintenance will occur when upgrading.

Both approaches have advantages and disadvantages, but I think it's better to follow a unified policy across the project, so we I modified it to use latest.

e93f3f2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bblommers bblommers added this to the 5.0.25 milestone Dec 22, 2024
@bblommers bblommers merged commit ab5ab27 into getmoto:master Dec 22, 2024
53 checks passed
@cm-iwata cm-iwata deleted the fix/terraform-test branch December 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants