Implement sort most popular sessions view #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update calendar view for schedule page
Reviewer's Guide by SourceryThis pull request implements sorting functionality in the calendar session view. It adds a sort dropdown menu and implements logic for sorting sessions by title, time, or popularity. The changes primarily affect the App.vue, LinearSchedule.vue, and Session.vue components, with additional new components created for the dropdown functionality. File-Level Changes
Tips
|
1 task
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @odkhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
src/components/LinearSchedule.vue
Outdated
Comment on lines
64
to
73
| return Object.entries(buckets).map(([date, sessions]) => { | ||
| let sessionBucket = {} | ||
| return Object.entries(buckets).map(([date, sessions]) => ({ | ||
| date: sessions[0].start, | ||
| // sort by room for stable sort across time buckets | ||
| sessions: sessions.sort((a, b) => this.rooms.findIndex(room => room.id === a.room.id) - this.rooms.findIndex(room => room.id === b.room.id)) | ||
| })) | ||
| } else { | ||
| let sortedSessions = this.sessions.slice().sort((a, b) => { | ||
| switch (this.sortBy) { | ||
| case 'title': | ||
| sessionBucket = { | ||
| date: sessions[0].start, | ||
| // sort by room for stable sort across time buckets | ||
| sessions: sessions.sort((a, b) => { | ||
| return a.title.localeCompare(b.title) | ||
| }) |
There was a problem hiding this comment.
suggestion (performance): Optimize sorting logic for better performance
The new sorting implementation in sessionBuckets computed property is more flexible but potentially less efficient for the 'time' sort case. Consider optimizing this logic, perhaps by maintaining separate sorted lists for each sort type and updating them incrementally as sessions change.
hongquan
requested changes
Aug 31, 2024
src/components/LinearSchedule.vue
Outdated
| return Object.entries(buckets).map(([date, sessions]) => ({ | ||
| date: sessions[0].start, | ||
| // sort by room for stable sort across time buckets | ||
| sessions: sessions.sort((a, b) => this.rooms.findIndex(room => room.id === a.room.id) - this.rooms.findIndex(room => room.id === b.room.id)) |
There was a problem hiding this comment.
This project already include lodash, please use "sort-by-key" strategy (https://lodash.com/docs/4.17.15#sortBy), it produces simpler code.
|
Hi @hongquan, fixed as your suggestion, please help me to review it again |
hongquan
requested changes
Sep 5, 2024
hongquan
requested changes
Sep 5, 2024
mariobehling
changed the title
hongquan
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/references issue fossasia/eventyay-talk#161 . It does so by:
Add sort dropdown in session view
implement logic when sort with title/time/popularity
Summary by Sourcery
Implement a sorting feature in the calendar session view, allowing users to sort sessions by title, time, or popularity. Introduce dropdown components for filtering sessions by tracks, rooms, and session types, and enhance the UI for better responsiveness and usability.
New Features:
Enhancements: