Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for sorting most popular sessions #188

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Aug 21, 2024

This PR closes/references issue #161 . It does so by:

  1. Add sort dropdown in session view
  2. implement logic when sort with title/time/popularity

How has this been tested?

Checklist

  • I have added tests to cover my changes.

@lcduong
Copy link
Contributor Author

lcduong commented Aug 21, 2024

image

image

image

@lcduong lcduong marked this pull request as ready for review August 21, 2024 08:46
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All of the files are larger than we can process. We're working on it!

@lcduong lcduong marked this pull request as draft August 21, 2024 08:52
@lcduong lcduong marked this pull request as ready for review August 21, 2024 09:06
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • All of the files are larger than we can process. We're working on it!
  • It looks like we've already tried to review the commit ff5943b in this pull request and failed.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. In the mobile view could you change the dropdown for popularity to an icon, please and move it in front of the "clear filters" icon similar to the previous eventyay version?

Screenshot from 2024-08-27 02-44-25

@odkhang
Copy link
Collaborator

odkhang commented Aug 28, 2024

image

Hi @mariobehling, updated as your request

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I also realized the "Add to Calendar" option is missing in the mobile version. Please add the icon into the mobile version (without the text "Add to Calendar" next to the version info.

@odkhang
Copy link
Collaborator

odkhang commented Aug 29, 2024

Hi @mariobehling, updated

image

@mariobehling mariobehling requested a review from hongquan August 29, 2024 05:52
@hongquan
Copy link
Member

Where is the source of src/prhttps://bitbucket.org/hescar/markaz/pull-requests/155etalx/static/agenda/js/pretalx-schedule.js file? Its content in this PR looks like the output of bundle process, not the source.

@odkhang
Copy link
Collaborator

odkhang commented Aug 30, 2024

Where is the source of src/prhttps://bitbucket.org/hescar/markaz/pull-requests/155etalx/static/agenda/js/pretalx-schedule.js file? Its content in this PR looks like the output of bundle process, not the source.

Hi @hongquan, pretalx-shedule.js is bundle of this plugin fossasia/eventyay-talk-schedule#12

@hongquan
Copy link
Member

hongquan commented Sep 5, 2024

The PR looks Ok, but unfortunately, it includes a code generated by fossasia/eventyay-talk-schedule#12, and the code in eventyay-talk-schedule PR is still in question, I cannot approve this PR yet.
But this PR is OK to merge if eventyay-talk-schedule PR is approved.

@mariobehling mariobehling merged commit 74765a9 into fossasia:development Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants