Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with VTK and glad #1631

Merged
merged 47 commits into from
Oct 16, 2024
Merged

Fix compatibility with VTK and glad #1631

merged 47 commits into from
Oct 16, 2024

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Sep 21, 2024

Fix compatibility with VTK master and the upcoming VTK 9.4 release.
VTK now uses glad instead of glew, making it possible to select GLX, EGL or OSMesa at runtime instead of building a specific backend.
Refactor the engine creation to use a factory in order to clarify which OpenGL context to use.

@Meakk Meakk self-assigned this Sep 21, 2024
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (da0a164) to head (a83b44e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   96.90%   97.01%   +0.10%     
==========================================
  Files         104      105       +1     
  Lines        7830     7935     +105     
==========================================
+ Hits         7588     7698     +110     
+ Misses        242      237       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

library/src/context.cxx Outdated Show resolved Hide resolved
library/src/context.cxx Outdated Show resolved Hide resolved
library/src/context.cxx Outdated Show resolved Hide resolved
library/src/context.cxx Outdated Show resolved Hide resolved
library/public/engine.h Outdated Show resolved Hide resolved
library/public/engine.h Outdated Show resolved Hide resolved
library/public/engine.h Outdated Show resolved Hide resolved
library/public/engine.h Outdated Show resolved Hide resolved
library/src/context.cxx Outdated Show resolved Hide resolved
library/src/context.cxx Outdated Show resolved Hide resolved
library/public/window.h Outdated Show resolved Hide resolved
doc/libf3d/CLASSES.md Outdated Show resolved Hide resolved
doc/dev/TESTING.md Outdated Show resolved Hide resolved
doc/libf3d/OVERVIEW.md Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@mwestphal mwestphal self-requested a review October 16, 2024 11:09
CMakeLists.txt Outdated Show resolved Hide resolved
doc/libf3d/CLASSES.md Outdated Show resolved Hide resolved
doc/libf3d/CLASSES.md Outdated Show resolved Hide resolved
doc/libf3d/CLASSES.md Outdated Show resolved Hide resolved
library/public/engine.h Outdated Show resolved Hide resolved
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

@mwestphal mwestphal self-requested a review October 16, 2024 13:28
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the regexp + baselines tests

@Meakk Meakk merged commit d9fa161 into f3d-app:master Oct 16, 2024
40 checks passed
@Meakk Meakk deleted the vtk-glad branch October 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants