Fix compatibility with VTK 9.3.20240914 #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meakk
reviewed
Sep 14, 2024
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 108 108
Lines 7643 7654 +11
=======================================
+ Hits 7400 7411 +11
Misses 243 243 ☔ View full report in Codecov by Sentry. |
VTK recently introduced support for dynamic loading of graphical libraries, breaking retro-compatibility in the process. This fix compatibility with VTK while also supporting implicitely EGL/OSMESA rendering with recent versions of VTK.
mwestphal
force-pushed
the
fix_VTK_opengl_glad
branch
from
865c5e7
to
cdd0047
Compare
mwestphal
commented
Sep 18, 2024
| @@ -981,15 +986,17 @@ if(NOT F3D_MACOS_BUNDLE) | |||
| endif() | |||
| endif() | |||
|
|
|||
| # TODO VTK_VERSION | |||
|
I'm taking over with #1631, let's close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTK recently introduced support for dynamic loading of graphical libraries, breaking retro-compatibility in the process.
This fix compatibility with VTK while also supporting implicitely EGL/OSMESA rendering with recent versions of VTK.
DISPLAY= ./bin/f3djust works now.Also updates VTK version in CI
Related to: #1445 #1621