Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a crossplane.yaml to the template #32

Closed
wants to merge 3 commits into from
Closed

adding a crossplane.yaml to the template #32

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24596fc
adding Crossplane yaml example
salaboy Apr 9, 2021
acbe842
suggesting new crossplane.yaml for the example
salaboy Apr 10, 2021
bb8d662
Update crossplane.yaml
salaboy Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ build: generate test
@CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o ./bin/$(PROVIDER_NAME)-controller cmd/provider/main.go

image: generate test
docker build . -t $(ORG_NAME)/$(PROVIDER_NAME):latest -f cluster/Dockerfile
docker build . -t $(ORG_NAME)/$(PROVIDER_NAME)-controller:latest -f cluster/Dockerfile

image-push:
docker push $(ORG_NAME)/$(PROVIDER_NAME):latest
docker push $(ORG_NAME)/$(PROVIDER_NAME)-controller:latest

run: generate
kubectl apply -f package/crds/ -R
Expand Down
13 changes: 13 additions & 0 deletions package/crossplane.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: meta.pkg.crossplane.io/v1alpha1
kind: Provider
metadata:
name: provider-template
annotations:
company: Template
maintainer: template <[email protected]>
source: github.com/crossplane/provider-template
license: Apache-2.0

spec:
controller:
image: crossplane/provider-template-controller:v0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

Suggested change
image: crossplane/provider-template-controller:v0.0.1
image: crossplane/provider-template-controller:latest

@salaboy maybe best to match the Makefile for now?