adding a crossplane.yaml to the template #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
|
I was thinking of improving the Readme file with the instructions to do that. |
|
@hasheddan hmm.. now that I am looking at this comment again.. what do you mean by and then to install the new provider So back to my previous comment, was more like adding those steps to the README in this repo. |
hasheddan
reviewed
May 27, 2021
package/crossplane.yaml
Outdated
|
|
||
| spec: | ||
| controller: | ||
| image: crossplane/provider-template-controller:v0.0.1 |
There was a problem hiding this comment.
nitpick:
Suggested change
| image: crossplane/provider-template-controller:v0.0.1 | |
| image: crossplane/provider-template-controller:latest |
@salaboy maybe best to match the Makefile for now?
|
@salaboy are you still interested in making this PR ready to merge? |
|
@muvaf I am .. let me get it done tomorrow early morning. |
|
@muvaf is there something else needed for this PR to be merged? |
|
Closing some very old PRs. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a crossplane.yaml example file to be able to package and distribute the provider.
This PR also includes a change in the name of the docker image generated by the make file adding
-controllerbecause I've seen in other providers and also in online tutorials that this pattern is being used.. For me, it was more clear to be able to differentiate the -controller image and the provider image.