Update mill.bat script including some fixes #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
changed the title
|
Supersedes #3284 |
lihaoyi
approved these changes
Jul 23, 2024
|
It's interesting, that this PR now also shows some build failures in the assembly test. Looks exactly as issue #3283, but with a different reproduction: Could be, that we previously always used the mill binary from Github, due to a bug in the script, and the newer version now uses binaries from Maven Central. Maybe they differ? |
|
So, I think we discovered that there are more issues in Windows CI then just the assembly test that we now have a fix for. Unfortunately, I already merged this, so we have a failing CI pipeline in |
|
No worries, we can just ignore the windows CI jobs for now and merge regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.