Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI seems to be broken on newer versions of Mill (500USD) #3283

Closed
lihaoyi opened this issue Jul 22, 2024 · 4 comments · Fixed by #3288 or #3322
Closed

Windows CI seems to be broken on newer versions of Mill (500USD) #3283

lihaoyi opened this issue Jul 22, 2024 · 4 comments · Fixed by #3288 or #3322

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jul 22, 2024


From the maintainer Li Haoyi: I'm putting a 500USD bounty on this issue, payable by bank transfer on a merged PR implementing this.


Ever since 126f574, the various Windows CI jobs seem to be finishing in ~1min, rather than the 10-30min they used to. Something's probably wrong and they're not actually testing anything. We should figure out what, fix it, and ensure Windows CI is able to pass on the current latest version of Mill built from HEAD

@lihaoyi lihaoyi changed the title Windows CI seems to be broken Windows CI seems to be broken on newer versions of Mill Jul 22, 2024
@lihaoyi lihaoyi changed the title Windows CI seems to be broken on newer versions of Mill Windows CI seems to be broken on newer versions of Mill (500USD) Jul 22, 2024
@lefou
Copy link
Member

lefou commented Jul 22, 2024

This PR only fixed the Windows batch script but doesn't raise the Mill version, yet it shows the same test failure:

We should compare the two binary sources Github releases and Maven Central as well as the batch script mill.bat which is a copy of https://github.com/lefou/millw.

@lefou lefou linked a pull request Jul 30, 2024 that will close this issue
@lihaoyi
Copy link
Member Author

lihaoyi commented Jul 30, 2024

Going to call this done. @sake92 since you made 2/4 of the fix PRs, I can pay out a proportionate amount of the bounty. Email me ([email protected]) your bank transfer details and I'll wire it over

@sake92
Copy link
Contributor

sake92 commented Jul 30, 2024

@lihaoyi thanks! I've sent you an email.

@lefou lefou added the bounty label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants