Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling recommendations using a CMDB class #2862

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controls/def.cf
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ bundle common def
expression => some( ".+", "def.control_executor_runagent_socket_allow_users" );

"cfengine_recommendations_enabled"
expression => "!cfengine_recommendations_disabled";
expression => "!cfengine_recommendations_disabled.!data:cfengine_recommendations_disabled";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of having multiple classes that do the same thing generally. This class is suggested because it's not clear how to define the class in MP CMDB UI, seems to me better to improve this elsewhere than add another class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I completely agree. This is really just my "user story" persona trying to scratch my own itch.


### Enable special features policies. Set to "any" to enable.

Expand Down
Loading