Allow disabling recommendations using a CMDB class #2862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMDB classes default to the `data` namespace. So if the user adds `cfengine_recommendations_disabled` as a class in their CMDB data for the hub machine, checking the class in the default namespace is not good enough to disable recommendations.
nickanderson
reviewed
Apr 2, 2024
| @@ -667,7 +667,7 @@ bundle common def | |||
| expression => some( ".+", "def.control_executor_runagent_socket_allow_users" ); | |||
|
|
|||
| "cfengine_recommendations_enabled" | |||
| expression => "!cfengine_recommendations_disabled"; | |||
| expression => "!cfengine_recommendations_disabled.!data:cfengine_recommendations_disabled"; | |||
There was a problem hiding this comment.
I am not a big fan of having multiple classes that do the same thing generally. This class is suggested because it's not clear how to define the class in MP CMDB UI, seems to me better to improve this elsewhere than add another class.
There was a problem hiding this comment.
Yes, I completely agree. This is really just my "user story" persona trying to scratch my own itch.
@vpodzime what do you think about this proposal? #2863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMDB classes default to the
datanamespace. So if the user addscfengine_recommendations_disabledas a class in their CMDB data for the hub machine, checking the class in the default namespace is not good enough to disable recommendations.