Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to typos hook #332

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

totoroot
Copy link
Collaborator

@totoroot totoroot commented Aug 3, 2023

Also sort options alphabetically.

Options added are:

  • color
  • exclude
  • hidden
  • locale

Also sort options alphabetically
@totoroot
Copy link
Collaborator Author

totoroot commented Aug 3, 2023

Discovered a typo using typos 😁

@totoroot totoroot changed the title Add options to 'typos' hook Add options to typos hook Aug 3, 2023
@domenkozar domenkozar merged commit 52bf404 into cachix:master Aug 3, 2023
4 checks passed
@totoroot totoroot deleted the add-options-typos-hook branch August 3, 2023 14:49
@totoroot
Copy link
Collaborator Author

totoroot commented Aug 3, 2023

Damn, I noticed that my changes broke the hook and that I could have fixed #291 as well...another PR incoming.
@domenkozar How can I best test changed hooks? 👀

@domenkozar
Copy link
Member

best to make an example and test it against :)

trueNAHO added a commit to trueNAHO/git-hooks.nix that referenced this pull request Nov 20, 2023
The 'settings.typos.exclude' should imply the '--force-exclude' option
in order to "Respect excluded files even for paths passed explicitly".

Follows:

- cachix#332
- crate-ci/typos@8314a15
totoroot pushed a commit to totoroot/git-hooks.nix that referenced this pull request Mar 27, 2024
The 'settings.typos.exclude' should imply the '--force-exclude' option
in order to "Respect excluded files even for paths passed explicitly".

Follows:

- cachix#332
- crate-ci/typos@8314a15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants