Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Function to copy derivatives #171

Merged
merged 36 commits into from
Apr 17, 2021
Merged

[WIP] Function to copy derivatives #171

merged 36 commits into from
Apr 17, 2021

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Feb 23, 2021

fixes #78

Added a functionderivate(BIDS, out_path, name, varargin) which exports the files from current BIDS layout into out_path/name folder. In other words exports data into derivatives.

varargin are the query options same as in bids.query, in fact they are passed directly to it.

To do (help needed!):

  • Options -- when created derivatives, there a list of usefull options to fine tune, but adding them will make list of parameters to long. Options that I would like to include are below.
  • Script add a line to dataset_description a new structure each time it is run. But on the third run it crashes (see below) referred into another PR.
  • Add version of bids-matlab (does it exists?) TODO when when have a version number.
  • Optimise the loop on files (see Provide easy way to loop over files as structure #161)
  • Copy of derivatives. Actually it supports only full paths in dependencies.*field. Refered in another issue
  • Copy of participants.tsv and scans.tsv files
  • Tests

Options

  • unzip -- if true, then zipped files are unzipped
  • copy_dependencies -- if true, the files that current file depend on are copied even if they are not explicitely queried
  • force -- copy file even if he already exists in output. Mutually exclusve with copy_dependencies to avoid circular copy

Crashes during dataset_description generation:

Error using horzcat
Dimensions of matrices being concatenated are not consistent.

Error in bids.derivate (line 68)
    description.GeneratedBy = [description.GeneratedBy pipeline];

@Remi-Gau Remi-Gau changed the title [WIP] Function to copy derivatives #162 [WIP] Function to copy derivatives Feb 23, 2021
@Remi-Gau
Copy link
Collaborator Author

PR #162 reopened from the feature branch

@Remi-Gau Remi-Gau mentioned this pull request Feb 23, 2021
7 tasks
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #171 (63a9b1b) into dev (c91f32d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #171   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      29    +4     
  Lines        933    1012   +79     
=====================================
- Misses       933    1012   +79     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
+bids/+internal/append_to_layout.m 0.00% <0.00%> (ø)
+bids/+internal/ends_with.m 0.00% <0.00%> (ø)
+bids/+internal/get_meta_list.m 0.00% <0.00%> (ø)
+bids/+internal/get_metadata.m 0.00% <0.00%> (ø)
+bids/+internal/parse_filename.m 0.00% <0.00%> (ø)
+bids/+internal/starts_with.m 0.00% <0.00%> (ø)
+bids/copy_to_derivative.m 0.00% <0.00%> (ø)
+bids/layout.m 0.00% <0.00%> (ø)
+bids/query.m 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91f32d...63a9b1b. Read the comment docs.

@Remi-Gau Remi-Gau linked an issue Apr 17, 2021 that may be closed by this pull request
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Apr 17, 2021

Once the tests check out green I will merge this into dev and open issues for the remaining TODOs

@Remi-Gau Remi-Gau merged commit 87655ae into dev Apr 17, 2021
@Remi-Gau Remi-Gau deleted the beliy-derivate branch April 17, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Initialize derivative data set with a copy of the raw data
1 participant