Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add clang-tidy job #4408

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ci: add clang-tidy job #4408

wants to merge 2 commits into from

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented Feb 7, 2024

Description of changes:

This commit adds a clang-tidy job to our CI

This is in preparation of the merging of #4404. Note that I am not disabling the clang-static-analyzer warnings, because most of those don't look like false positives. Rather I will put out PR's to fix those before I make this a required check.

Call-outs:

This will likely stay in draft for a while until

I also have a cppcheck job written, but the new cppcheck introduces a large number of new lints, so we either have a lot of things to fix or a lot of things to suppress.

Testing:

I verified that new codebuild job runs correctly (although it is currently failing)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit adds clang-tidy.
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant