Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit adds a clang-tidy job to our CI
This is in preparation of the merging of #4404. Note that I am not disabling the clang-static-analyzer warnings, because most of those don't look like false positives. Rather I will put out PR's to fix those before I make this a required check.
Call-outs:
This will likely stay in draft for a while until
I also have a cppcheck job written, but the new cppcheck introduces a large number of new lints, so we either have a lot of things to fix or a lot of things to suppress.
Testing:
I verified that new codebuild job runs correctly (although it is currently failing)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.