refactor: clang-tidy null deref and undefined mod #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the warning that clang tidy emits about null references and the undefined results of taking some modulus 0.
The current behavior relies on the stuffer permitting null pointers as long as the length is zero. This commit update the new check to match that.
- refactor to avoid pointer arithmetic with null pointer
- since the guard macros introduced a new loop, the manual loop "pinning" behavior has to be updated.
CBMC is too wily, and can not be contained. The manual attempt to set all of the loop indicides turned out the be unsuccessful.
Same problem as the previous proof, the manual attempt to avoid cbmc's fragile loop specifications has been empirically demonstrated to be of little worth.
goatgoose
reviewed
Mar 6, 2024
- make the free and pkey check independent of each other.
goatgoose
approved these changes
Mar 6, 2024
lrstewart
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clang tidy warnings
n % 0is a no-go)Inspired by the work in #4049 😄
Description of changes:
The CBMC changes are necessary because the Guard Macros add new loops into the function definitions, so the main loop is no longer the
4th loop, but rather the10th loop.s2n_stuffer_write_reservationand friends contains a large collection ofUNWINDSETs to try and avoid this exact situation: reference. However this has been empirically demonstrated to be of questionable effectiveness 😄.Call-outs:
I also updated #4408 with the new lints to prevent any regressions.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.