Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): respond in chat right away when user enters JDK path #6275

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(amazonq): respond in chat right away when user enters JDK path #6275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54bba3c
fix(amazonq): respond in chat right away when user enters JDK path
Dec 18, 2024
3904e34
address comments
Dec 20, 2024
75381b6
fix lint
Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-a9be5502-257b-4c77-b632-94515dd68bf0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Amazon Q Code Transformation: respond immediately when entering JAVA_HOME path"
}
3 changes: 3 additions & 0 deletions packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { CodeTransformTelemetryState } from '../../../amazonqGumby/telemetry/cod
import { ToolkitError } from '../../../shared/errors'
import { writeLogs } from './transformFileHandler'
import { throwIfCancelled } from './transformApiHandler'
import { sleep } from '../../../shared/utilities/timeoutUtils'

// run 'install' with either 'mvnw.cmd', './mvnw', or 'mvn' (if wrapper exists, we use that, otherwise we use regular 'mvn')
function installProjectDependencies(dependenciesFolder: FolderInfo, modulePath: string) {
Expand Down Expand Up @@ -108,6 +109,8 @@ function copyProjectDependencies(dependenciesFolder: FolderInfo, modulePath: str
}

export async function prepareProjectDependencies(dependenciesFolder: FolderInfo, rootPomPath: string) {
// sleep for 0.5s to allow QCT to 1) process JAVA_HOME path and 2) send multiple chat messages
await sleep(500)
try {
copyProjectDependencies(dependenciesFolder, rootPomPath)
} catch (err) {
Expand Down
Loading