-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amazonq): respond in chat right away when user enters JDK path #6275
base: master
Are you sure you want to change the base?
Conversation
|
Problem (on latest version of Q): Screen.Recording.2024-12-18.at.2.38.20.PM.movSolution (this PR): Screen.Recording.2024-12-18.at.2.39.47.PM.mov |
So users on fast systems must always wait 500ms? And, what happens on systems where it takes longer than 500ms? |
@@ -108,6 +108,7 @@ function copyProjectDependencies(dependenciesFolder: FolderInfo, modulePath: str | |||
} | |||
|
|||
export async function prepareProjectDependencies(dependenciesFolder: FolderInfo, rootPomPath: string) { | |||
void vscode.window.showInformationMessage(CodeWhispererConstants.buildStartedNotification) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this here anyway as an unrelated change, but still need to figure out a better solution besides sleeping for half a second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the few chat messages which should be showing up one-at-a-time before the copyProjectDependencies
and installProjectDependencies
functions below start, are actually showing up all at once after both of these functions complete. I guess that means these 2 functions are blocking the event loop, which is why adding a small delay before they begin provides enough time for the queued chat messages to send. Haven't been able to find another solution besides adding this delay.
Downsides are that it does delay for all users, and unclear if 500ms will always be enough of a delay.
Problem
On a VS Code instance backed by CloudFront, when users enter their JDK path, it takes our chat 30+ seconds to respond.
Solution
Send a notification just before the build starts to also allow the other multiple chat messages to be sent.
feature/x
branches will not be squash-merged at release time.