Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete properties & methods (Part 1) #3401

Conversation

peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Jul 26, 2024

…etframework and netstandard. Update obsolete methods in commontest projects

Description

This is the first part of a multi-pr effort to remove obsolete properties, methods, and classes from core for v4. This PR address

  1. Removing obsolete properties from AWSConfigs and ClientConfig / IClientConfig
  2. Refactoring existing integ tests (specifically for clock skews) to not use obsolete properties
  3. Make UnmarshallerAsync and sync codepath consistent on when to read the entire response
  4. In AssertExtensions.cs, update SHA256 providers to use non-obsolete methods to remove warnings.

Motivation and Context

Testing

Ran the affected integ/unit tests that passed.

Full build of AWSSDK.NetFramework and AWSSDK.NetStandard Solution.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@peterrsongg peterrsongg force-pushed the petesong/remove-obsolete-classes-from-core branch 2 times, most recently from 98aaf5f to 0e53a9f Compare July 26, 2024 17:13
…etframework and netstandard. Update obsolete methods in commontest projects
@peterrsongg peterrsongg force-pushed the petesong/remove-obsolete-classes-from-core branch from 0e53a9f to 9ccc04f Compare July 26, 2024 17:14
@ashovlin ashovlin requested a review from muhammad-othman July 26, 2024 17:29
@peterrsongg peterrsongg added the v4 label Jul 26, 2024
@ashovlin ashovlin requested a review from afroz429 July 26, 2024 17:31
@normj
Copy link
Member

normj commented Jul 31, 2024

Be sure to update the v4 tracker issue when this is merged. #3362

@peterrsongg peterrsongg merged commit 7244bd3 into petesong/remove-obsolete-classes-from-core-final Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants