Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete classes from core (final) #3431

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Remove obsolete classes from core (final) #3431

merged 4 commits into from
Aug 8, 2024

Conversation

peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Aug 8, 2024 •
edited
Loading

Description

The 2 previous PR's have already been approved:
#3406
#3401

This PR includes 2 small commits that fix issues that popped up in the dry run

Motivation and Context

Testing

Dry run in v4 prod passed

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@peterrsongg peterrsongg merged commit 0c5879b into v4-development Aug 8, 2024
5 checks passed
@peterrsongg peterrsongg deleted the petesong/remove-obsolete-classes-from-core branch August 8, 2024 23:03
dscpinheiro added a commit that referenced this pull request Aug 13, 2024
@dscpinheiro
Revert "Remove obsolete classes from core (final) (#3431)"
f0ddb1d 
This reverts commit 0c5879b.
peterrsongg pushed a commit that referenced this pull request Aug 14, 2024
@dscpinheiro
Revert "Remove obsolete classes from core (final) (#3431)" (#3440)
05815e2 
This reverts commit 0c5879b.
peterrsongg added a commit that referenced this pull request Aug 19, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
b86bf17 
* refactor: remove obsolete classes from core and refactor.
peterrsongg added a commit that referenced this pull request Aug 23, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
c225730 
* refactor: remove obsolete classes from core and refactor.
peterrsongg added a commit that referenced this pull request Aug 26, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
98077ec 
* refactor: remove obsolete classes from core and refactor.
peterrsongg added a commit that referenced this pull request Aug 28, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
1c7395c 
* refactor: remove obsolete classes from core and refactor.
peterrsongg added a commit that referenced this pull request Sep 3, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
ff568a1 
* refactor: remove obsolete classes from core and refactor.
peterrsongg added a commit that referenced this pull request Sep 25, 2024
@peterrsongg
Remove obsolete classes from core (final) (#3431)
51f749b 
* refactor: remove obsolete classes from core and refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammad-othman muhammad-othman muhammad-othman approved these changes

@normj normj normj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterrsongg @normj @muhammad-othman