Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Include/Exclude Interface for AWS Lambda Builders #516

Open
mildaniel opened this issue Jun 12, 2023 · 3 comments
Open
Labels
type/feature Feature request

Comments

@mildaniel
Copy link
Contributor

Describe your idea/feature/enhancement

There are currently two opposing feature requests that go hand-in-hand. One is to include files/directories in the resultant build package, and one is for exclusion. Both of these are genuine use-cases across various runtimes, and, as such, we believe should be handled together though a common include/exclude interface for the Lambda Builders library.

Include: Issue #430, PR #431
Exclude: Issue #185, PR #424

This should start with an initial design document, and once approved, can be implemented. The important notes for the design to address:

  • What does the interface look like? e.g. is part of the JSON RPC, is it through a configuration file, etc?
  • How to make the implementation general across runtimes. Are there any runtimes for which this feature should be ignored?
@mildaniel mildaniel added type/feature Feature request stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jun 12, 2023
@AdrianCarreno
Copy link

I think the functionality should be just like .gitignore or .dockerignore. Just have a .samignore file where you would put every path you don't want in the build.

@farridav
Copy link

👍 Having an optional .samignore file that overides the hardcoded EXCLUDED_FILES seems like natural behaviour to me, afterall

Explicit is better than implicit - Zen of Python

It fits with developer expectations set by many other mature tools and could easily be a non breaking change by defaulting to the hardcoded EXCLUDED_FILES when this file is not present..

@ishan1608
Copy link

Has there any progress been made on this so far, to come up with a decision?
We are facing similar stuff in our project, where we have a bunch of stuff like tests, tools etc. being added to the deployed code which we don't really need and is also causing our bundled zip files to become bloated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants