Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include files other than JS in final SAM deployment #5633

Closed
ulissesferreira opened this issue Jul 27, 2023 · 2 comments
Closed

Include files other than JS in final SAM deployment #5633

ulissesferreira opened this issue Jul 27, 2023 · 2 comments
Labels

Comments

@ulissesferreira
Copy link

Hello all,

I have seen a common pattern in APIs that are powered by lambdas where database migrations are made using one of those lambdas (just not exposed as part of the API). While playing around with this setup I have noticed that if you use esbuild to bundle your lambdas you don't get the needed SQL files to run your migrations shipped when you deploy them.

Running the sam build command removes all other files that are not JS and source maps.

Am I missing something or is this a legitimate problem?

Thank you

@ulissesferreira ulissesferreira added the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Jul 27, 2023
@moelasmar moelasmar added type/feature Feature request type/question and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 27, 2023
@moelasmar
Copy link
Contributor

Thanks @ulissesferreira for raising this issue. Currently SAM CLI does not support adding any files that do not related to the lambda function code to the build output. We already have this feature request to cover this case. I am going to close your issue as it is duplicate with the Lambda Builder's feature request. Please keep an eye on the Lambda Builder's issue to keep updated.

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants