Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: build with .git directory for version info #6356

Closed
kaihendry opened this issue Nov 28, 2023 · 2 comments
Closed

Feature request: build with .git directory for version info #6356

kaihendry opened this issue Nov 28, 2023 · 2 comments
Labels
type/feature Feature request

Comments

@kaihendry
Copy link

Describe your idea/feature/enhancement

Include .git repository in build so that build identifiers (version) can be included.

Proposal

When building via BuildMethod: makefile allow for .git directory to build copied in.

Things to consider:

  1. Will this require any updates to the SAM Spec - No

Additional Details

https://github.com/kaihendry/days/actions/runs/7024444798/job/19113205820#step:6:32 shows that sam builds in a tmp dir without .git directory. I am not sure how this works, though it should also have the option of bringing in the .git directory too to solve this.

@kaihendry kaihendry added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Nov 28, 2023
@lucashuy
Copy link
Contributor

lucashuy commented Nov 30, 2023

Thanks for raising this feature request! We have a similar aggregate issue on Lambda Builders (the library we use to power the building process in SAM CLI) that contains a request to have some sort of "including" functionality, similar to your request to include the .git folder.

We can close this issue in favour for the one in Lambda Builders if there aren't any concerns, or things that are specific to SAM CLI that'd you like to see get introduced.

@lucashuy lucashuy removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Nov 30, 2023
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants